search

skylarstein / bme280-sensor

A Node.js I2C module for the Bosch BME280 Humidity, Barometric Pressure, and Temperature Sensor
MIT License
35 stars 22 forks source link

Added basic support for the BMP280 version of the chip. #2

Closed gopherspidey closed 7 years ago

gopherspidey commented 7 years ago

Still need to disable the humidity sections, because the BMP280 does not have a humidity sensor. Currently the humidity returns 0 and not errors.

skylarstein commented 7 years ago

Thank you for the contribution and sorry for the delay. :) Let me get back to this later today.

skylarstein commented 7 years ago

This is now included in v0.1.6. I'm not too concerned with returning non-error humidity zeros for the BMP280 since it keeps things clean by avoiding special case BMP280 code. It does mean a couple wasted bytes on an existing i2c read and some unnecessary arithmetic when running a BMP280... A worry for another time perhaps. :)

gopherspidey commented 7 years ago

Great thanks I will let you know if I run into anything as my project continues.

On Jan 12, 2017 12:41 AM, "Skylar Stein" notifications@github.com wrote:

This is now included in v0.1.6. I'm not too concerned with returning non-error humidity zeros for the BMP280 since it keeps things clean by avoiding special case BMP280 code. It does mean a couple wasted bytes on an existing i2c read and some unnecessary arithmetic when running a BMP280... A worry for another time perhaps. :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/skylarstein/bme280-sensor/pull/2#issuecomment-272088719, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdwbyK9c5E-XZveK2a1_IqFIAzqGV3nks5rRcscgaJpZM4LdfN1 .