search

skylarweaver / front-end-afa

🏍💨💨Gatsby + Netlify CMS site for Adventures for Alopecia, a nonprofit founded by Skylar
https://www.ProjectAFA.org
Other
1 stars 2 forks source link

Fix wording #14

Closed bkrainer closed 3 years ago

bkrainer commented 4 years ago

updates "treatments options" to "treatment options"

jkcorrea commented 4 years ago

Not so sure about this one. Have you discussed this change with marketing? It could be the case that the "treatment's (possessive noun) options become more effective and less detrimental" , in which case an apostrophe should be added.

Also, in the future please use proper commit messages.

bkrainer commented 4 years ago

@jkcorrea thanks for the feedback. Really great, wish I could just merge your feedback directly into my code it's that good haha. Don't have a marketing team , actually , as we are a small off-shore dev shop. I've taken your feedback into account verbatim. Mind taking another pass at this?

cc @skylarweaver

bkrainer commented 4 years ago

As for the previous build failure, I have narrowed it down between an issue with netlify, github, or the general architecture of the internet. As all of these things would be pretty heavy lifts, I propose merging this as-is and adding an issue to this project.

skylarweaver commented 3 years ago

Ah yes many thanks @bkrainer for pointing this out. While I'll close this PR b/c the text change won't work and we don't want to merge directly into Prod, I do appreciate you raising the issue regarding the "internet". Indeed it looks like we will need to refactor that. Adding it to the neverlog.