search

skyleague / therefore

Therefore, the JSON Schema toolkit for TypeScript.
https://skyleague.io
MIT License
5 stars 1 forks source link

Using ky as a client, still requires got as a devDependency when generating code #175

Open eugenpodaru opened 3 days ago

eugenpodaru commented 3 days ago

Description

Since got is used in https://github.com/skyleague/therefore/blob/main/src/common/json/json.ts which is in turn used by the restclient builder, it is not possible to remove got as a (dev) dependency even when using ky as the http client.

Expectation

When using ky as a client, got should not be required as a dependency, or therefore should mark got as a dependency instead of as a devDependency

pevisscher commented 18 hours ago

Fixed by #176

eugenpodaru commented 18 hours ago

Great, thank you! Will test it as soon as it's released.