skylightio / skylight-phoenix

Skylight agent for Phoenix
Other
28 stars 5 forks source link

Fetch Skylight native assets when compiling #2

Closed JonRCahill closed 6 years ago

JonRCahill commented 7 years ago

When previously compiling if the native Skylight assets were not present then only the bootstrap files for the Skylight app would be compiled with a message prompting to download the native assets using mix skylight.fetch. This had the following issues:

This pull request then changes compiling the Skylight app so it downloads, extracts and compiles the native assets to fix all the above issues. Additionally, if any of these critical steps cannot be completed then the elixir compile explicitly fails so the recompile issues don't arise.

cla-bot[bot] commented 6 years ago

We require contributors to sign our Contributor License Agreement, and we don't have @zvkemp on file. In order for us to review and merge your code, please sign the CLA.

wagenet commented 6 years ago

@cla-bot check

cla-bot[bot] commented 6 years ago

The cla-bot has been summoned, and re-checked this pull request!