skylineprof / skyline

🏙 Interactive in-editor performance profiling, visualization, and debugging for PyTorch neural networks.
Apache License 2.0
30 stars 3 forks source link

Mechanism to ensure protobuf generated code is kept up to date #16

Open geoffxy opened 4 years ago

geoffxy commented 4 years ago

When we update protobuf files, we need to ensure that the developer does not forget to check in the updated generated code. One way to accomplish this could be to use a git hook to warn* users if changes to protobuf files are not accompanied by changes to the generated code.

*We want to warn users because there are certain changes that will not change the generated code (e.g., changing comments in the protobuf file).