search

skylineprof / skyline

🏙 Interactive in-editor performance profiling, visualization, and debugging for PyTorch neural networks.
Apache License 2.0
30 stars 3 forks source link

Avoid profiling inconsequential operations #48

Closed geoffxy closed 4 years ago

geoffxy commented 4 years ago

Due to how we profile operations (i.e. we use monkey-patched hooks), we end up profiling inconsequential operations like dim, size, etc. These operations are not useful to have in the profile because they are metadata operations. They often get attributed to other more important code lines (e.g., batch norm and dim), which is undesirable for the end-user's understandability.

geoffxy commented 4 years ago

Fixed in commits 802c1e4a6ee361a792caf25e2d92c79ab95c9543 and 553570dd3e456ea00afb649cda6023e78494e0cb.