search

skylot / jadx

Dex to Java decompiler
Apache License 2.0
41.37k stars 4.85k forks source link

[feature] Improve Color schemes #1101

Open Surendrajat opened 3 years ago

Surendrajat commented 3 years ago

Describe your idea: Symbol highlights, selections etc. are not clearly distinguishable in monokai and other dark themes. Default theme can be improved as well.

Smali colors are kinda broken with comments and all. I'm not sure how syntax highlighting is implemented but this .tmLanguage syntax definition can be used as it works very well.

skylot commented 3 years ago

@Surendrajat sure, currently this color hardcoded: https://github.com/skylot/jadx/blob/ffb2956d90444d90c25ba8091505e87a5259be77/jadx-gui/src/main/java/jadx/gui/ui/codearea/AbstractCodeArea.java#L33

We must change it to one of the standard color defined in color theme (default one for example), so it will change in different themes.

Smali colors are kinda broken

RSyntaxTextArea don't support smali syntax right now. @alissonlauffer already open issue for this: https://github.com/bobbylight/RSyntaxTextArea/issues/364. And I already tried to do it myself, but it is harder than I thought, so I need to put more effort to finish it :smile:

Surendrajat commented 3 years ago

RSyntaxTextArea don't support smali syntax right now.

Then it can't be helped much :)

Anyway I will try to fix Java color schemes.