[core] Resource table is being parsed twice

pubiqq commented 3 months ago

This bug used to only increase parsing time, but now because of it and b85900a, resources are being generated with double entries.

Screenshot

![](https://github.com/user-attachments/assets/29571ea2-1b85-440d-83a0-302fd6f11aaa)

skylot commented 2 months ago

Fixed. Some details:

actually running decode of arsc file twice is fine. First time needed to collect some info used during decompilation (like mapping to replace resource IDs with res names in code). And second time is lazy loading/generation of resource xml files. So second time is optional (not invoked in jadx-gui if user not open arsc file content).
issue was introduced in PR #2165 by keeping parser instance in memory like a singleton, so second decode was adding arsc entries again.
I changed code to not store parser instance and also, just in case, to create entries storage right before decode to prevent possible duplication.

@pubiqq thank you for report, it was very helpful :+1:

pubiqq commented 2 months ago

Honestly I was rather hoping that the solution would be to cache the ResourceStorage, and then the resources wouldn't have to be re-decoded.

Well, at least the resources are no longer duplicated now.

skylot / jadx