skylot / jadx

Dex to Java decompiler
Apache License 2.0
41.99k stars 4.9k forks source link

[core] Compact resource entries are not supported #2268

Closed pubiqq closed 2 months ago

pubiqq commented 2 months ago

Issue details

https://cs.android.com/android/platform/superproject/+/android15-release:frameworks/base/libs/androidfw/include/androidfw/ResourceTypes.h;l=1547-1549

Jadx version

1.5.0

pubiqq commented 2 months ago

Sample here.

skylot commented 2 months ago

Fixed. At least sample is parsed without errors now :rofl:

pubiqq commented 2 months ago

Fixed. At least sample is parsed without errors now 🤣

Indeed, albeit not without some problems:

Screenshot

![](https://github.com/user-attachments/assets/2dde1723-0e89-4409-a6e9-8a2f6ceec5a4)

I'm going to create an issue about it on Monday, unless you fix it sooner, of course 🤣.

skylot commented 2 months ago

@pubiqq looks like these resources have different configs but same qualifiers string, this mean we miss some new config fields. In this sample, we always skip the last 12 bytes in config data, so we need to support these new flags/fields. I will create a new issue and implement this myself.

PR from ApkTool as a reference: https://github.com/iBotPeaches/Apktool/pull/3206