search

skylot / jadx

Dex to Java decompiler
Apache License 2.0
41.99k stars 4.9k forks source link

feat: Add button to go to Android Manifest #2296

Closed xiaojye closed 1 month ago

xiaojye commented 1 month ago

Icons from: https://intellij-icons.jetbrains.design/#AllIcons-expui-fileTypes-manifest Closes https://github.com/skylot/jadx/issues/2297

jpstotz commented 1 month ago

As Jadx can not only process Android apps but also regular Java code the name "Go to Manifest" may be misleading, as a non-Android developer would interpret it as "Go to META-INF/MANIFEST.MF". Therefore I would recommend to change it in strings to the full name "AndroidManifest.xml" respectively in code to "AndroidManifest".

xiaojye commented 1 month ago

As Jadx can not only process Android apps but also regular Java code the name "Go to Manifest" may be misleading, as a non-Android developer would interpret it as "Go to META-INF/MANIFEST.MF". Therefore I would recommend to change it in strings to the full name "AndroidManifest.xml" respectively in code to "AndroidManifest".

Good suggestion, optimized and modified. Please refer to the latest commit https://github.com/skylot/jadx/pull/2296/commits/ffaefd2c3cc6469d62ee80b144a1c23c78e87644

xiaojye commented 1 month ago

Use icon from intellij-icons.jetbrains.design, all icons in jadx used from here.

Good suggestion, optimized and modified. Please refer to the latest commit https://github.com/skylot/jadx/pull/2296/commits/ffaefd2c3cc6469d62ee80b144a1c23c78e87644