search

skymakerolof / dxf

DXF parser for node/browser
https://www.npmjs.com/package/dxf
MIT License
335 stars 122 forks source link

added LTYPE table parser. Necessary to create patterns for dashed lines #120

Closed ieskudero closed 1 year ago

ieskudero commented 1 year ago

LTYPE tables are used to get line properties, such as patterns to create dashed lines. This allows to use the lineTypeName property common to all entities. With this dxf viewers can create non continuous lines.

skymakerolof commented 1 year ago

Sounds like a good improvement feature-wise! The diff is huge however and from what I can see it is mostly formatting that has changed. Would it be possible to revert that so that the diff only includes implementation changes? Would also be nice with some test case that shows how it is supposed to work.

ieskudero commented 1 year ago

My mistake, didn't realize that before uploading it. I will try to fix this, or if I can't I will upload another PR with a use case included.

ieskudero commented 1 year ago

@skymakerolof you can close this PR. #121 fixes it. By the way, can you upload a new version of the library?