search

skymeyer / Vatsimphp

Vatsimphp - VATSIM data parser
http://skymeyer.github.io/Vatsimphp/
Apache License 2.0
29 stars 7 forks source link

JSON v3 - ATIS data is in a separate block #41

Open CaptainStealthy opened 3 years ago

CaptainStealthy commented 3 years ago

Looking at the code for the v3 parser, it only looks at objects within the controllers and pilots blocks, and ignores the atis block.

https://github.com/skymeyer/Vatsimphp/blob/60eb40c0bcf7dd58060ae529073fa25eb455dedd/src/Vatsimphp/Parser/DataV3CompatParser.php#L167

Would it be possible to have ATIS data added?

skymeyer commented 3 years ago

I'll take a look over the weekend what we are missing.

Regardless of that, I have some newer code sitting ready so we can abandon the legacy format all together which will make everyone's life easier.

winternet-studio commented 2 years ago

Regardless of that, I have some newer code sitting ready so we can abandon the legacy format all together which will make everyone's life easier.

Is this code still using some of the legacy format as of today?

skymeyer commented 2 years ago

I have been pretty busy the last months and completely overlooked finishing this up. The new code solely makes use of the JSON data simplifying the whole code base.