search

skymoore / required-approvals

Github Action to check PR approvals and codeowners
7 stars 6 forks source link

counting approvals twice #1

Closed skymoore closed 1 year ago

skymoore commented 1 year ago 
2023-04-19 23:35:42 [INFO] Starting required-approvals action
2023-04-19 23:35:43 [INFO] Required codeowners: {'frontend': False, 'backend': False, 'infra': False}
2023-04-19 23:35:44 [INFO] Found 9 reviews for PR 3 (another test query):
2023-04-19 23:35:44 [INFO] Reviews: 
2023-04-19 23:35:46 [INFO]   skymoore APPROVED: at commit: e6b0b510a58e99f3add1703cff26fb4aa1f90e3b for: infra (not the latest commit, ignoring)
2023-04-19 23:35:58 [INFO]   skymoore APPROVED: at commit: 1de6965e9c221d5dda5f8ee0d8b4cd42da987cb7 for: infra (not the latest commit, ignoring)
2023-04-19 23:36:01 [INFO]   skymoore APPROVED: at commit: 43782caf3dcde013baca1dcd80a67649496b8dc4 for: infra (not the latest commit, ignoring)
2023-04-19 23:36:04 [INFO]   skymoore APPROVED: at commit: 08c7778974a45ad05bd5876677941929d8e1b591 for: infra
2023-04-19 23:36:06 [INFO]   skymoore APPROVED: at commit: 08c7778974a45ad05bd5876677941929d8e1b591 for: infra
Warning: 9 23:36:06 [WARNING] Required approvals not met: not all codeowners approved and total approvals:2 < minimum approvals:3

At first glance, probably just need to find statements like this and make sure that review.user.login isn't already in the approved_codeowners list.

skymoore commented 1 year ago

fixed in v3