skymoore / required-approvals

Github Action to check PR approvals and codeowners
7 stars 6 forks source link

fix: allign patterns check logic with Github ones #17

Closed AlvaroGG0 closed 1 month ago

AlvaroGG0 commented 1 month ago

The current verification of patterns does not follow the same logic as Github's when they do not start with /, which causes Codeowners to mismatch in these cases.

From Github documentation:

# In this example, @octocat owns any file in an apps directory
# anywhere in your repository.
apps/ @octocat

Changes made:

skymoore commented 1 month ago

@AlvaroGG0 Looks good to me, thank you for the contribution!

skymoore commented 1 month ago

@AlvaroGG0 https://github.com/skymoore/required-approvals/releases/tag/v4.2.2

skymoore commented 1 month ago

@AlvaroGG0 I invited you as a collaborator to the repository. It seems you are using this action a lot more than I am at the moment. Would appreciate your help here.