search

skymoore / required-approvals

Github Action to check PR approvals and codeowners
7 stars 6 forks source link

Make reviewer login comparison case-insesnitive #2

Closed sysradium closed 8 months ago

sysradium commented 9 months ago

The reason behind the PR is that here https://github.com/skymoore/required-approvals/blob/fafc45c70f282cd9a7c9571bb24e282938c7eb92/src/index.js#L50 usernames in CODEWNERS are being lowercased. However say, here, https://github.com/skymoore/required-approvals/blob/fafc45c70f282cd9a7c9571bb24e282938c7eb92/src/index.js#L174 an original login is being used for comparisson. It was either stop lowercasing usernames under CODEOWNERS, or try doing it everywhere. I thought having a case-insensitive check is a good thing.

skymoore commented 8 months ago

Thank you @sysradium. Appreciate the contribution.