skynetservices / skydns

DNS service discovery for etcd
MIT License
2.2k stars 305 forks source link

Did not manage to build a given version #258

Open hervenicol opened 8 years ago

hervenicol commented 8 years ago

Trying to build 2.5.3a:

$ git clone https://github.com/skynetservices/skydns.git -q -b 2.5.3a .
$ go get -v
github.com/skynetservices/skydns (download)
package github.com/skynetservices/skydns/stats: cannot find package "github.com/skynetservices/skydns/stats" in any of:
    /usr/lib/go/src/github.com/skynetservices/skydns/stats (from $GOROOT)
    /go/src/github.com/docker/Godeps/_workspace/src/github.com/skynetservices/skydns/stats (from $GOPATH)
    /go/src/github.com/skynetservices/skydns/stats

One useful tool would be godep, but:

$ godep restore -v
godep: open Godeps/Godeps.json: no such file or directory

Works well with master branch, of course.

miekg commented 8 years ago

[ Quoting notifications@github.com in "[skydns] Did not manage to build a ..." ]

Trying to build 2.5.3a:

$ git clone https://github.com/skynetservices/skydns.git -q -b 2.5.3a .
$ go get -v
github.com/skynetservices/skydns (download)
package github.com/skynetservices/skydns/stats: cannot find package "github.com/skynetservices/skydns/stats" in any of:
  /usr/lib/go/src/github.com/skynetservices/skydns/stats (from $GOROOT)
  /go/src/github.com/docker/Godeps/_workspace/src/github.com/skynetservices/skydns/stats (from $GOPATH)
  /go/src/github.com/skynetservices/skydns/stats

I probably messed up tagging this :(

One useful tool would be godep, but:

$ godep restore -v
godep: open Godeps/Godeps.json: no such file or directory

Can't stand Godeps, my try the vendoring of go 1.6, but not looking forward to vender a large chunk of etcd.

Dynom commented 8 years ago

[off topic] I'm not really liking Go's "vendoring" also, especially since we have gopkg.in [/off topic]

I managed to build it just fine like so:

$ git checkout 2.5.3a && go get -v && echo $?
HEAD is now at 8688008... version 2.5.3a
github.com/coreos/go-etcd (download)
github.com/ugorji/go (download)
github.com/rcrowley/go-metrics (download)
github.com/stathat/go (download)
github.com/stathat/go
github.com/rcrowley/go-metrics
github.com/ugorji/go/codec
github.com/rcrowley/go-metrics/stathat
github.com/coreos/go-etcd/etcd
github.com/skynetservices/skydns/backends/etcd
github.com/skynetservices/skydns/server
github.com/skynetservices/skydns/stats
github.com/skynetservices/skydns
0
hervenicol commented 8 years ago

Maybe you have some previous references to the now-missing package?

Here is a more deterministic way to reproduce, from a clean environment, using Docker:

$ docker run -ti ubuntu:16.04 bash
root@e937e4498a2e:/# apt-get update && apt-get install -y golang git
[...]
root@e937e4498a2e:/# mkdir -p /go/src
root@e937e4498a2e:/# export GOPATH=/go
root@e937e4498a2e:/# cd /go/src
root@e937e4498a2e:/go/src# git clone http://github.com/skynetservices/skydns.git
Cloning into 'skydns'...
remote: Counting objects: 2916, done.
remote: Compressing objects: 100% (17/17), done.
remote: Total 2916 (delta 5), reused 0 (delta 0), pack-reused 2899
Receiving objects: 100% (2916/2916), 914.29 KiB | 328.00 KiB/s, done.
Resolving deltas: 100% (1943/1943), done.
Checking connectivity... done.
root@e937e4498a2e:/go/src# cd skydns/
root@e937e4498a2e:/go/src/skydns# git checkout 2.5.3a && go get -v && echo $?
Note: checking out '2.5.3a'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 8688008... version 2.5.3a
github.com/coreos/go-etcd (download)
github.com/ugorji/go (download)
github.com/miekg/dns (download)
github.com/skynetservices/skydns (download)
github.com/coreos/etcd (download)
Fetching https://golang.org/x/net/context?go-get=1
Parsing meta tags from https://golang.org/x/net/context?go-get=1 (status code 200)
get "golang.org/x/net/context": found meta tag main.metaImport{Prefix:"golang.org/x/net", VCS:"git", RepoRoot:"https://go.googlesource.com/net"} at https://golang.org/x/net/context?go-get=1
get "golang.org/x/net/context": verifying non-authoritative meta tag
Fetching https://golang.org/x/net?go-get=1
Parsing meta tags from https://golang.org/x/net?go-get=1 (status code 200)
golang.org/x/net (download)
github.com/coreos/go-systemd (download)
github.com/prometheus/client_golang (download)
github.com/beorn7/perks (download)
github.com/golang/protobuf (download)
github.com/prometheus/client_model (download)
github.com/prometheus/common (download)
github.com/matttproud/golang_protobuf_extensions (download)
github.com/prometheus/procfs (download)
package github.com/skynetservices/skydns/stats: cannot find package "github.com/skynetservices/skydns/stats" in any of:
    /usr/lib/go/src/github.com/skynetservices/skydns/stats (from $GOROOT)
    /go/src/github.com/skynetservices/skydns/stats (from $GOPATH)
root@e937e4498a2e:/go/src/skydns# go version
go version go1.6 linux/amd64
root@e937e4498a2e:/go/src/skydns# 
Dynom commented 8 years ago

highly peculiar, since stats is part of the repository:

$ git ls-files | grep stats
server/stats.go
stats/graphite.go

I'm on OSX, could it be that there is a casing problem somewhere that causes this situation? @miekg you seem a Linux kinda guy, but are you on OSX with a case-insensitive FS by chance?

miekg commented 8 years ago

Nope. This was all typed and created with linux On 7 Mar 2016 17:17, "Mark van der Velden" notifications@github.com wrote:

highly peculiar, since stats is part of the repository:

$ git ls-files | grep stats server/stats.go stats/graphite.go

I'm on OSX, could it be that there is a casing problem somewhere that causes this situation? @miekg https://github.com/miekg you seem a Linux kinda guy, but are you on OSX with a case-insensitive FS by chance?

— Reply to this email directly or view it on GitHub https://github.com/skynetservices/skydns/issues/258#issuecomment-193354688 .