skynetservices / skydns

DNS service discovery for etcd
MIT License
2.2k stars 307 forks source link

Move systemd code to linux-only built files #345

Open fanatic opened 6 years ago

fanatic commented 6 years ago

This moves systemd activation to a build tagged file to allow skydns to be built on Windows. For issue #212

JaysLiang commented 6 years ago

@fanatic can you install this on windows? I always get error when install on windows (the problem is about systemd)

fanatic commented 6 years ago

Yeah, this change disables the systemd activation code when built on Windows - but there are some other code that assumes Linux (like reading from /etc/resolv.conf to determine default dns settings). However, since this allows skydns to be built on Windows, I'm able to use it as a library in my Go code.

JaysLiang commented 6 years ago

@fanatic thanks, but i still can not install skydns. I think some other part code may also use the package "systemd". I don't know how to fixed that.

derit commented 3 years ago

@JaysLiang i has tested to compile @fanatic code on windows without error