Closed wyardley closed 2 years ago
Errors such as: "failure to return reply" and similar should (IMHO) go to stderr vs. stdout.
Currently, these lines are using logf() vs fatalf().
logf()
fatalf()
https://github.com/skynetservices/skydns/blob/15f42ac021b1f17a8b329f409539aa1624458da0/server/server.go#L193-L195
IMHO, fatalf()should either be renamed, or a third error type created, and then any errors (even non-fatal ones) should go to stderr.
Errors such as: "failure to return reply" and similar should (IMHO) go to stderr vs. stdout.
Currently, these lines are using
logf()vsfatalf().https://github.com/skynetservices/skydns/blob/15f42ac021b1f17a8b329f409539aa1624458da0/server/server.go#L193-L195
IMHO,
fatalf()should either be renamed, or a third error type created, and then any errors (even non-fatal ones) should go to stderr.