search

skynetservices / skydns

DNS service discovery for etcd
MIT License
2.2k stars 307 forks source link

Use prometheus client 1.1.0 #350

Closed prameshj closed 4 years ago

prameshj commented 5 years ago

The current constraint is to use 0.8.0.

This causes some dependency issue in our repo - https://github.com/kubernetes/dns/blob/master/Gopkg.toml We want to use newer coreDNS versions that use a newer prometheus golang client. The change in this PR will help with that.

prameshj commented 5 years ago

/assign @erikstmartin

prameshj commented 5 years ago

/assign @miekg

bowei commented 5 years ago

:wave: @miekg :o)

bowei commented 4 years ago

@miekg -- this will allow us to upgrade the version of CoreDNS being used by the Kubernetes node local cache.

miekg commented 4 years ago

I've removed myself from this project (I think), I'll check if I can still merge

On Fri, 11 Oct 2019, 21:21 Bowei Du, notifications@github.com wrote:

@miekg https://github.com/miekg -- this will allow us to upgrade the version of CoreDNS being used by the Kubernetes node local cache.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/skynetservices/skydns/pull/350?email_source=notifications&email_token=AACWIW3BFLQLROLISGGQQC3QODN3VA5CNFSM4HTA2YO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBBDO5A#issuecomment-541210484, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACWIW44VRR3AXEGEXGFKYLQODN3VANCNFSM4HTA2YOQ .

miekg commented 4 years ago

yes, I'm out

miekg commented 4 years ago

I'm out of this project. I you need want things ask Erik to add you as a maintainer or you need to fork it and maintain it. The overhead of doing and being involved in these smaller things is just too much.

On Fri, 11 Oct 2019, 22:52 Miek Gieben, miek@miek.nl wrote:

I've removed myself from this project (I think), I'll check if I can still merge

On Fri, 11 Oct 2019, 21:21 Bowei Du, notifications@github.com wrote:

@miekg https://github.com/miekg -- this will allow us to upgrade the version of CoreDNS being used by the Kubernetes node local cache.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/skynetservices/skydns/pull/350?email_source=notifications&email_token=AACWIW3BFLQLROLISGGQQC3QODN3VA5CNFSM4HTA2YO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBBDO5A#issuecomment-541210484, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACWIW44VRR3AXEGEXGFKYLQODN3VANCNFSM4HTA2YOQ .

bowei commented 4 years ago

Thanks @miekg and @erikstmartin. I owe you :beers:

prameshj commented 4 years ago

Thanks so much @miekg , @erikstmartin !