search

skynetservices / skydns1

DNS for skynet or any other service discovery
MIT License
528 stars 54 forks source link

Allow skydns itself to use env variables #60

Closed miekg closed 10 years ago

miekg commented 10 years ago

Reuse the variables defined in skydnsctl for skydns itself. Also rename them slightly to keep the two much more in sync.

SKYDNS_DNSPORT -> SKYDNS_DNS (something like 127.0.0.1:1053) in stead of a number SKYDNS_DNSDOMAIN -> SKYDNS_DOMAIN (a string like skydns.local)

The environment variable SKYDNS is used in skydns, the prefix http:// is removed before use. This might confuse people.

Sadly this is a minor backward incompatible change, because skydns.NewClient needed to be changed

bketelsen commented 10 years ago

lgtm @crosbymichael Ok by you?

crosbymichael commented 10 years ago

LGTM