search

skynetservices / skydns1

DNS for skynet or any other service discovery
MIT License
528 stars 54 forks source link

converting dots #70

Closed miekg closed 10 years ago

miekg commented 10 years ago

Right now a Name or Version with dots in it gets converted to a hyphen. From a DNS perspective this is unnecessary, but skydns splits everything on a dot, so changing this breaks skydns quite fundamentally.

But it is also non obvious that querying for 1.0.1, should be done with 1-0-1. It may be an idea to reject requests with dots in them and only allow version strings like 1-0-1 when registering.

erikstmartin commented 10 years ago

It should be converting .'s in the versions to - on Add() is that not the case anymore?

miekg commented 10 years ago

[ Quoting notifications@github.com in "Re: [skydns] converting dots (#70)..." ]

It should be converting .'s in the versions to - on Add() is that not the case anymore?

It should... If not (anymore), that is a bug that someone (prolly me) introduced.

/Miek

Miek Gieben

miekg commented 10 years ago

dropped in skydns2.