search

skynetservices / skydns1

DNS for skynet or any other service discovery
MIT License
528 stars 54 forks source link

Add DNSSEC to SkyDNS #71

Closed miekg closed 10 years ago

miekg commented 10 years ago

This adds DNSSEC. Functionality works. But it still need add more testing to check if the spec. is fully followed. If DNSSEC is not enabled the new code isn't used, so this should not trigger any unwanted behaviour in the non-DNSSEC case.

I'm putting this PR out now, because its already large. Future tweaks and more tests will come in subsequent PRs.

bketelsen commented 10 years ago

holy moly!

bketelsen commented 10 years ago

this doesn't merge cleanly since I merged the stat PR. Can you pull latest?

crosbymichael commented 10 years ago

I'll try to help and review this soon

miekg commented 10 years ago

@bketelsen hmmm, should I then pull master into my dnssec branch? If so, I just did that.

crosbymichael commented 10 years ago

@miekg It is usually more advantageous to do a rebase from upstream instead of a merge. The merge will still work in this case.

miekg commented 10 years ago

Local test works, seems like Travis isn't fast enough: some TTLs have the wrong value

miekg commented 10 years ago

Woot! On 12 Feb 2014 11:26, "Brian Ketelsen" notifications@github.com wrote:

Merged #71 https://github.com/skynetservices/skydns/pull/71.

— Reply to this email directly or view it on GitHubhttps://github.com/skynetservices/skydns/pull/71 .