search

skynetservices / skydns1

DNS for skynet or any other service discovery
MIT License
528 stars 54 forks source link

Add round robin replies for A and AAAA replies #73

Closed miekg closed 10 years ago

crosbymichael commented 10 years ago

Is this going to cause issues with sessions if this is the default and cannot be turned off?

miekg commented 10 years ago

I was contemplating an option. What is a session in this context?

Note that you can never depend on the RR order in an dns message. On 9 Feb 2014 03:55, "Michael Crosby" notifications@github.com wrote:

Is this going to cause issues with sessions if this is the default and cannot be turned off?

— Reply to this email directly or view it on GitHubhttps://github.com/skynetservices/skydns/pull/73#issuecomment-34563894 .

miekg commented 10 years ago

Add a -noroundrobin option to skydns.

bketelsen commented 10 years ago

i like defaulting it.

miekg commented 10 years ago

Tot clarify: defaulting to... Round robin?

Would a better idea be to load balance according to weight and prio, if we have that info? Just a thought. On 11 Feb 2014 19:38, "Brian Ketelsen" notifications@github.com wrote:

i like defaulting it.

— Reply to this email directly or view it on GitHubhttps://github.com/skynetservices/skydns/pull/73#issuecomment-34796428 .

miekg commented 10 years ago

But that would be much much harder as we need a history of served replies. On 11 Feb 2014 19:43, "Miek Gieben" miek@miek.nl wrote:

Tot clarify: defaulting to... Round robin?

Would a better idea be to load balance according to weight and prio, if we have that info? Just a thought. On 11 Feb 2014 19:38, "Brian Ketelsen" notifications@github.com wrote:

i like defaulting it.

— Reply to this email directly or view it on GitHubhttps://github.com/skynetservices/skydns/pull/73#issuecomment-34796428 .

crosbymichael commented 10 years ago

LGTM

bketelsen commented 10 years ago

LGTM

miekg commented 10 years ago

rebase, merge, rebase, edit. Should be in good shape now.