skynetservices / skydns1

DNS for skynet or any other service discovery
MIT License
528 stars 54 forks source link

Bugfix: don't reply to names that are too long. #76

Closed miekg closed 10 years ago

miekg commented 10 years ago

This closes #67

bketelsen commented 10 years ago

What's the status on this? Is it needed?

miekg commented 10 years ago

This is still be needed, but longer names can just be nxdomained. Something this does not happen now iirc On 29 Mar 2014 18:00, "Brian Ketelsen" notifications@github.com wrote:

What's the status on this? Is it needed?

— Reply to this email directly or view it on GitHubhttps://github.com/skynetservices/skydns/pull/76#issuecomment-39003397 .

miekg commented 10 years ago

Ok, I've clean up this PR, rebased it to the latest, added some docs and most important removed my < 4 which was clearly wrong.