search

skypackjs / skypack-cdn

An issue tracker for the CDN
107 stars 5 forks source link

unexpected `/error/` path #144

Open ioslh opened 3 years ago

ioslh commented 3 years ago

Try this url https://cdn.skypack.dev/dva which imports from https://cdn.skypack.dev/-/dva@v2.4.1-TKonj4ObB03zkuupQawd/dist=es2020,mode=imports/optimized/dva.js , and the later url script contains import https://cdn.skypack.dev/error/build:dva-core@v1.4.0-Agv17b4rPIEl0OgnW85g?from=dva

The /error path is not expected.

image

drwpow commented 3 years ago

It looks like we did have a bug that has since been resolved; in the latest build of dva I’m no longer seeing that error.

However, I am getting a new error, where the history package is required as a deep dependency, and history still has some Node.js runtime code (specifically process.env, where process is not defined in a browser). So I think dva may have some difficulties running in a browser as long as it uses dependencies with Node.js runtime code (it may work if we stripped out some process.env code like webpack does, but we’ve been hesitant to start doing that).