search

skypackjs / skypack-cdn

An issue tracker for the CDN
107 stars 5 forks source link

Importing `react-markdown` (v7) includes a “broken” version of `micromark`, which was fixed before react-markdown@7 came out #210

Open wooorm opened 3 years ago

wooorm commented 3 years ago

Steps to reproduce:

<!doctype html>
<script type="module">
  import ReactMarkdown from 'https://cdn.skypack.dev/react-markdown'
  console.log(ReactMarkdown)
</script>

Yields:

https://cdn.skypack.dev/error/build:micromark@v3.0.2-dlbu5mTz0KCz84aj5UCR?from=mdast-util-from-markdown

But, what I’m now wondering is,

a) how did micromark@3.0.2 end up in the react-markdown@7.0.0 bundle? Because micromark@3.0.3 was released 22 days ago, whereas react-markdown was released 12 days ago?

b) what is the policy on updating/pulling in patches of deep dependencies, especially given a broken build?

c) lastly, micromark had an entry map in its export map for a file that was not in package.json#files, but this specific export entry was not used in mdast-util-from-markdown, perhaps such non-applicable errors could be handled gracefully?

rabahmilano commented 3 years ago

Hello Sir, is it possible to use this package in codepen pen ?