search

skypackjs / skypack-cdn

An issue tracker for the CDN
107 stars 5 forks source link

Pinned link isn't minified for some modules #331

Open thdoan opened 1 year ago

thdoan commented 1 year ago

I am trying to load a pinned equivalent of https://cdn.jsdelivr.net/npm/three@0.145.0/examples/jsm/controls/OrbitControls.min.js, but it's not returning the minified code:

https://cdn.skypack.dev/three@v0.145.0/examples/jsm/controls/OrbitControls.js

 *   ⏩ Minified: https://cdn.skypack.dev/pin/three@v0.145.0-QB3GbCVEL6cwWpW43q6J/mode=raw,min/examples/jsm/controls/OrbitControls.js

The pinned link leads to this:

export * from '/-/three@v0.145.0-QB3GbCVEL6cwWpW43q6J/dist=es2020,mode=raw,min/examples/jsm/controls/OrbitControls.js';

Which loads a non-minified version: https://cdn.skypack.dev/-/three@v0.145.0-QB3GbCVEL6cwWpW43q6J/dist=es2020,mode=raw,min/examples/jsm/controls/OrbitControls.js

I'm not sure if this is a bug in generating minified pinned links or I'm using an incorrect procedure.

UPDATE: Using the ?min option also doesn't minify it:

https://cdn.skypack.dev/three@v0.145.0/examples/jsm/controls/OrbitControls?min