search

skypackjs / skypack-cdn

An issue tracker for the CDN
107 stars 5 forks source link

[Package Issue] Pinned dependency version not being respected. #66

Open smurrayatwork opened 4 years ago

smurrayatwork commented 4 years ago

A package I support, @massds/mayflower-react currently depends on the specific package dom-helpers@3.4.0.

When using the skypack cdn, we're seeing an error reporting that mayflower react is unable to be built due to not being able to resolve dom-helpers/style. dom-helpers/style is removed in the latest version of the dom-helpers package, but we're not yet on that. Our package.json file for mayflower react is specifically set to 3.4.0 for dom-helpers, but it appears that skypack is trying to grab the latest version of the dependency instead. Can someone help with this?

Thanks!

FredKSchott commented 4 years ago

Interesting, that's not expected. Will dig in to see why this is happening. Thanks for reporting!

drwpow commented 4 years ago

Investigated a little; it looks like our installer (esinstall) correctly grabs the right version, but I believe when resolving, the CDN points to the wrong version of dom-helpers like @smurrayatwork says

drwpow commented 3 years ago

Just wanted to give an update on this. This isn‘t outlined anywhere, but dom-helpers is one of our “special” packages, because it’s a utility library. Much like how if a library uses a single lodash function, it’s better to simply inline that one function than make a new request to the entire library, we do the same with dom-helpers. However in this scenario we include a more recent version than your package is expecting. We are looking to address this with our next major update to the CDN.