AWS Dependenices pin Colorama to a lower version

skypilot-org / skypilot

SkyPilot: Run LLMs, AI, and Batch jobs on any cloud. Get maximum savings, highest GPU availability, and managed execution—all with a simple interface.

https://skypilot.readthedocs.io

Apache License 2.0

6.22k stars 427 forks source link

AWS Dependenices pin Colorama to a lower version #3701

Open hemildesai opened 1 week ago

hemildesai commented 1 week ago

AWS Dependencies pin colorama to < 0.4.5 here. Is there a particular reason to do so?

AWS CLI has updated the colorama requirements here

Is it possible to update this? This requirements prevents lockfiles to be created when skypilot is used with other dependencies that depend on newer colorama versions.

I'm happy to contribute a PR for this, but unsure what tests to run.

Michaelvll commented 6 days ago

We pinned the colorama version just for AWS CLI dependencies, if AWS has published a new pypi release of AWS CLI with the new requirements, it should be good to upgrade our dependencies as well.

Please help submit a PR for this by increasing the version number for both aws cli and colorama. In our setup.py, we can use the lowest possible aws-cli version that has updated colorama to make sure the best compatibility. : )