Fix `stream_logs` Duplicate Job Handling and TypeError - Githubissues

skypilot-org / skypilot

SkyPilot: Run AI and batch jobs on any infra (Kubernetes or 12+ clouds). Get unified execution, cost savings, and high GPU availability via a simple interface.

https://skypilot.readthedocs.io

Apache License 2.0

6.82k stars 513 forks source link

Fix `stream_logs` Duplicate Job Handling and TypeError #4274

Closed andylizf closed 2 weeks ago

andylizf commented 2 weeks ago

Fixes #4273

Use Set[int] to manage unique job_ids for duplicate job names.
Raise ValueError with improved messaging if multiple jobs with the same name exist.
Import ux_utils for clearer error display.

This fix prevents type errors and ensures clearer handling of duplicate job names.

Tested (run the relevant ones):

[x] Code formatting: bash format.sh
[x] Any manual or new tests for this PR (please specify below)
- Fix sky jobs logs --controller --name =pipeline
[ ] All smoke tests: pytest tests/test_smoke.py
[ ] Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
[ ] Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

andylizf commented 2 weeks ago

@cblmemo PTAL, thanks!