[Core][Docker] Support docker login on RunPod.

skypilot-org / skypilot

SkyPilot: Run AI and batch jobs on any infra (Kubernetes or 12+ clouds). Get unified execution, cost savings, and high GPU availability via a simple interface.

https://skypilot.readthedocs.io

Apache License 2.0

6.82k stars 513 forks source link

[Core][Docker] Support docker login on RunPod. #4287

Open cblmemo opened 2 weeks ago

cblmemo commented 2 weeks ago

Fixes #4269.

TODO: Testing, cleanup after cluster termination.

Tested (run the relevant ones):

[ ] Code formatting: bash format.sh
[ ] Any manual or new tests for this PR (please specify below)
[ ] All smoke tests: pytest tests/test_smoke.py
[ ] Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
[ ] Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

cblmemo commented 2 weeks ago

Maybe they are including the server name in the image name.