skypilot-org / skypilot

SkyPilot: Run AI and batch jobs on any infra (Kubernetes or 12+ clouds). Get unified execution, cost savings, and high GPU availability via a simple interface.
https://skypilot.readthedocs.io
Apache License 2.0
6.82k stars 513 forks source link

[AWS] Not robust identity checking #4350

Closed Michaelvll closed 1 week ago

Michaelvll commented 1 week ago

I create a ~/.aws/credentials with a wrong key file, and I log in with aws sso with AWS_PROFILE env var set. The AWS CLIs picks up the SSO credentials correctly with aws configure list and aws sts get-caller-identity, but sky check aws shows

Details: `aws sts get-caller-identity` failed with error: [botocore.exceptions.ClientError] An error occurred (SignatureDoesNotMatch) when calling the GetCallerIdentity operation: The request signature we calculated does not match the signature you provided. Check your AWS Secret Access Key and signing method. Consult the service documentation for details..
Michaelvll commented 1 week ago

This is a false alarm... Was using a wrong branch.