search

skypjack / entt

Gaming meets modern C++ - a fast and reliable entity component system (ECS) and much more
https://github.com/skypjack/entt/wiki
MIT License
9.6k stars 844 forks source link

3.13.0 installs include/BUILD.bazel #1104

Closed yurivict closed 4 months ago

yurivict commented 4 months ago

Could you please remove it?

skypjack commented 4 months ago

Out of curiosity, was it there in the previous version? I don't think anything has changed in the meantime but I could be wrong. 🤔

yurivict commented 4 months ago

No, it wasn't there in 3.12.2

skypjack commented 4 months ago

I think this is eligible for the next patch version. Can you test a patch when it's upstream and before adding it to the new release? Just to confirm that it works as expected. I think I can push it on Monday (mostly because I'm out until then 😅).

zaucy commented 4 months ago

Sorry this was introduced by me during bzlmod support. I don't use cmake much these days and didn't catch it 😅

Here's a patch https://github.com/skypjack/entt/pull/1107

skypjack commented 4 months ago

No worries at all @zaucy and thanks for your help! 🙂

skypjack commented 4 months ago

Fix available on branches wip and v3.13.x (next patch release for version 3.13). Let me know if it doesn't work for you. Thanks. 👍

skypjack commented 4 months ago

Fixed with version 3.13.1, thanks for pointing this out.

skypjack commented 2 months ago

@zaucy before trying to fix it on my own, I think it's worth to ping you 🙂 bazel is complaining since a while ago, see here for an example. Is it an easy fix? Any suggestions? Thanks in advance for your help. 🙏

zaucy commented 2 months ago

@skypjack done! it's here https://github.com/skypjack/entt/pull/1124

skypjack commented 2 months ago

Oh, wow @zaucy thank you very much!! ❤️