search

skypjack / entt

Gaming meets modern C++ - a fast and reliable entity component system (ECS) and much more
https://github.com/skypjack/entt/wiki
MIT License
9.6k stars 844 forks source link

bazel version and compatibility number out of sync #1141

Open zaucy opened 1 month ago

zaucy commented 1 month ago

The current release process doesn't increment the version or compatibility level in the MODULE.bazel file. I've recently submitted EnTT to the BCR and had to patch it in (so no worries there.)

I'm creating this issue for visibility sake, but I plan on creating a PR to fix this myself in the coming weeks.

edit:

https://github.com/bazelbuild/bazel-central-registry/pull/1904#discussion_r1583814621

The current advice is to avoid compatibility_level altogether so it would probably be best to omit it for now until EnTT introduces some major breaking changes.

skypjack commented 3 days ago

@zaucy can I close this issue?

zaucy commented 2 days ago

thanks for the reminder! with https://github.com/skypjack/entt/pull/1147 it can be.

zaucy commented 2 days ago

although the version number is still not automatically updated. Is there a release script I could update?

Typically I would update the version via buildozer like so:

buildozer "set version $VERSION" //MODULE.bazel:%module

I'm willing to put in the work. How do you typically update the version of things like ENTT_VERSION_MINOR? Is it a manual process?

skypjack commented 1 day ago

I usually update version.h, then I read it from cmake.