search

skypjack / uvw

Header-only, event based, tiny and easy to use libuv wrapper in modern C++ - now available as also shared/static library!
MIT License
1.87k stars 211 forks source link

Cross-platform support to shared libs #207

Closed stefanofiorentino closed 4 years ago

stefanofiorentino commented 4 years ago

closes #196

stefanofiorentino commented 4 years ago

This is intended for comparing against the current HEAD. NOTE: still contains minor flaws about FakeEvent/Emitter test classses.

stefanofiorentino commented 4 years ago

@skypjack this is the best solution I can find to have cross-platform support to shared libs. In my opinion the question rose by @amurzeau is right, do we want to fully support shared libs too? From my point of view, the price is simplicity and readability.

skypjack commented 4 years ago

From my point of view, the price is simplicity and readability.

Do you mean not supporting them? Because this change isn't exactly simple nor easy to read. :smile:

stefanofiorentino commented 4 years ago

I mean we can support only static linking (not the shared one). The simplicity and readability will be impacted a lot by this mod.

skypjack commented 4 years ago

The simplicity and readability will be impacted a lot by this mod.

Indeed, it doesn't seem to be something simple to maintain.

stefanofiorentino commented 4 years ago

I'll close this as per discussion.