search

skypjack / uvw

Header-only, event based, tiny and easy to use libuv wrapper in modern C++ - now available as also shared/static library!
MIT License
1.84k stars 209 forks source link

fix undefined behavior of Loop::walk #215

Closed darsvador closed 4 years ago

darsvador commented 4 years ago

Close #214

Passed all tests with ASAN and UBSAN.

skypjack commented 4 years ago

This doesn't convince me to be honest. There are some things that can cause problems in the short term. Let me look into it.

skypjack commented 4 years ago

Please, see the discussion on #214 and branch experimental for further details. Thanks.

darsvador commented 4 years ago

https://github.com/skypjack/uvw/commit/0b329720bfd938af22a59a47d72aa1ef7094de58 is better implementation options, close it.