skypjack / uvw

Header-only, event based, tiny and easy to use libuv wrapper in modern C++ - now available as also shared/static library!
MIT License
1.84k stars 209 forks source link

Shadow warning in fs.h #230

Closed stefanofiorentino closed 3 years ago

stefanofiorentino commented 3 years ago

I've just reorganized some warning flags and got this on GCC 7.5.0

`uvw/src/uvw/fs.h:359:9: warning: declaration of ‘name’ shadows a member of ‘uvw::FsEvent<(uvw::details::UVFsType)32>’ [-Wshadow]
[build]          : name{name}, type{type}, eos{eos}

Same for type and eos. I assign it to myself and work on it asap.

skypjack commented 3 years ago

Hi @stefanofiorentino any news on this? Can I close the issue? Even better, if you could share the flags you used, I can look into the warnings and try to fix them on my own. Thanks.

stefanofiorentino commented 3 years ago

I'll close this one as cannot reproduce. Next time I'll link to the commit and the .vscode/settings