search

skypjack / uvw

Header-only, event based, tiny and easy to use libuv wrapper in modern C++ - now available as also shared/static library!
MIT License
1.82k stars 207 forks source link

The library targets are not versioned. #268

Closed stefanofiorentino closed 1 year ago

stefanofiorentino commented 1 year ago

Working on the Yocto Project meta-layer to natively list uvw in the OpenEmbedded Layer index and this sample application (the application delivered by uvw inside the test folder, brought in a separated repo), I got the error that the libraries provided (and installed) by this CMake-based project are not versioned (best-practice is that the libuvw.so lib is a symlink to the versioned "concrete" libuvw.so.2.11.2). I'll work on it.

skypjack commented 1 year ago

Cool, thank you!! Is it a problem to also port these changes to the v3 branch? From what I see, the libuv crew is working on a v2 of the library and I'd like to merge our rework in the meantime.

stefanofiorentino commented 1 year ago

Of course yes, let's cherry-pick it once the PR got approved, ok?

skypjack commented 1 year ago

Can we close this one? 🤔

stefanofiorentino commented 1 year ago

the PR is still not merged (because of 'required' workflows we not support anymore). I cannot remove this blockers from the settings by myself, sorry for this.

skypjack commented 1 year ago

Oho cuz I'm stupid! 😅 I merged only one of them, sorry. Is it ready? Also, what about removing the required checks? I want you to be able to proceed on your own, since I trust you 100%.

stefanofiorentino commented 1 year ago

I agree with removing the required checks. The PR is ok to me.

skypjack commented 1 year ago

I think you can merge it now? Just to double check that the required checks were turned off. 🙂