search

skypjack / uvw

Header-only, event based, tiny and easy to use libuv wrapper in modern C++ - now available as also shared/static library!
MIT License
1.88k stars 211 forks source link

fix missing const in equality relation for C++23 #278

Closed jopadan closed 1 year ago

skypjack commented 1 year ago

I'm sorry but I really don't see why this is meant to fix something and how it does it. Can you elaborate a little, please? Thanks.

jopadan commented 1 year ago

The library doesn't compile with g++ -std=gnu++23 only with g++ -std=gnu++17 without the changes

skypjack commented 1 year ago

Yeah, I'm asking why C++23 requires it because it looks odd to be honest. You didn't really answer my question though. As it stands, it sounds more like - it didn't compile and we tried to fix it one attempt at a time until it worked. 🤷‍♂️