Closed ReimuNotMoe closed 1 year ago
You're definitely right on handle<poll_handle, uv_poll_t, details::uvw_poll_event>
. 👍
On the other hand, I'd rather change the using declaration to 🤔 poll_event_flags
(we used a similar pattern somewhere else too) and use it in the class.
I don't like using details::xxx
names in an API, it's odd and somewhat risky.
Do you mind updating the PR?
You're definitely right on
handle<poll_handle, uv_poll_t, details::uvw_poll_event>
. +1 On the other hand, I'd rather change the using declaration to thinkingpoll_event_flags
(we used a similar pattern somewhere else too) and use it in the class. I don't like usingdetails::xxx
names in an API, it's odd and somewhat risky.Do you mind updating the PR?
Of course I don't mind.
The line
created an ambiguous alias with the same name as the
struct poll_event
.And
poll_handle
should be inheritinghandle<poll_handle, uv_poll_t, poll_event>
instead ofhandle<poll_handle, uv_poll_t, details::uvw_poll_event>
if I'm understanding correctly. Otherwiseon<uvw::poll_event>()
doesn't work.