search

skypjack / uvw

Header-only, event based, tiny and easy to use libuv wrapper in modern C++ - now available as also shared/static library!
MIT License
1.82k stars 207 forks source link

fix undefined uint32_t error on 2.12.1 under GCC 13 #288

Closed fcelda closed 1 year ago

fcelda commented 1 year ago

uvw 2.12.1 currently doesn't compile with GCC 13 (Fedora 38) because type_info.hpp doesn't have correct include for standard integers.

/home/fcelda/devel/uvw/src/uvw/type_info.hpp:17:37: error: ‘uint32_t’ in namespace ‘std’ does not name a type; did you mean ‘wint_t’?
   17 | [[nodiscard]] static constexpr std::uint32_t fnv1a(const char *curr) noexcept {
      |                                     ^~~~~~~~
      |                                     wint_t

Standard integers are defined in cstdint. The removed header cstdef seems unused.

fcelda commented 1 year ago

Oh. It looks like this has been fixed already. :+1: Thanks.