Fix compiler warnings in `test` directory

skypjack / uvw

Header-only, event based, tiny and easy to use libuv wrapper in modern C++ - now available as also shared/static library!

MIT License

1.82k stars 207 forks source link

Fix compiler warnings in `test` directory #302

Closed aloisklink closed 11 months ago

aloisklink commented 1 year ago

Fixes a couple of compiler warnings in the test directory.

Since the test directory doesn't affect users, I've just made a single PR that includes all my changes. But please let me know if you'd prefer to break my changes up into smaller PRs (I've tried to split up each change into individual commits, to make it a bit easier to review!)

aloisklink commented 11 months ago

I've dropped commit https://github.com/skypjack/uvw/commit/628b60339559339f6bb4089199f3d6af05841149 as discussed in https://github.com/skypjack/uvw/pull/302#discussion_r1311405389, since https://github.com/skypjack/uvw/commit/dea293ffaa5ee68c0152531e03453935a44bbfcb has already fixed this issue.

I'm not 100% sure why CI is failing, but I'm guessing it might just be a random failure, since everything seems to be working on my aloisklink/uvw fork: https://github.com/aloisklink/uvw/commit/b820447a60d49a8a3c8503930366918f76515089. Can you re-run GitHub Actions and see if that fixes it?