search

skyportal / gwemopt

Gravitational-wave Electromagnetic Optimization
GNU General Public License v3.0
19 stars 34 forks source link

Always do Observability? #127

Closed robertdstein closed 3 months ago

robertdstein commented 1 year ago

It appears that "--doObservability" makes a big difference to the generated schedules. It does not take very long. If it more correct behaviour, should we just require it? There are a ton of if statements related to this in the code, and the "reasonable default" is not clear to me.

robertdstein commented 1 year ago

(cc #90 )

robertdstein commented 1 year ago

Per additional discussion, it is not clear that the functionality is actually useful for plans, and it is definitely true that the function was not used in O3. Perhaps it should be purely a plotting feature. Needs investigation.

mcoughlin commented 3 months ago

Removed from the codebase.