search

skyportal / gwemopt

Gravitational-wave Electromagnetic Optimization
GNU General Public License v3.0
19 stars 34 forks source link

Addition of ULTRASAT Configuration Files #153

Closed weizmannk closed 7 months ago

weizmannk commented 7 months ago

This pull request introduces a series of updates to the gwemopt project. The updates include the inclusion of ULTRASAT configuration files, the addition of "params" to the lightcurve module to allow direct capture of filters specified by the user via the command line instead of using a fixed default filters, the introduction of arguments for location and observability, and the implementation of observability thresholds.

weizmannk commented 7 months ago

Hi! @mcoughlin Here is the pull request. Now, everything should be okay as it's working fine. However, the warning is still present (you know we already discuss about it and you were waitting for @Theodlz . Another issue I've encountered is that I cannot use the --doMovie argument because ffmpeg, as referenced here https://github.com/skyportal/gwemopt/blob/main/gwemopt/plotting/movie.py#L21, is not functioning, and I'm unsure how to fix it. I was running it on LHO, so I didn't have sudo access to install this package. Could you please explain what exactly ffmpeg is and how I can install it on a server without sudo privileges?

mcoughlin commented 7 months ago

@weizmannk Can you please run your pre-commit and fix the linting on these files?

weizmannk commented 7 months ago

@mcoughlin It's done but I still see that Some checks were not successful .