search

skyportal / gwemopt

Gravitational-wave Electromagnetic Optimization
GNU General Public License v3.0
19 stars 34 forks source link

Lines out of loop in samplers.py #65

Closed JTBaird91 closed 1 year ago

JTBaird91 commented 2 years ago

Lines 254-259 of samplers.py need to be adjusted out one space to align with the for loop iterating over each tile ID. Otherwise the 'greedy' schedule only returns a dictionary with the last tile attributes saved and all other tiles entries empty.

mcoughlin commented 2 years ago

We don't use samplers much anymore. Can you submit a quick PR?

JTBaird91 commented 2 years ago

Ah ok. Yes I am currently just exploring the code and the default schedule was 'greedy'. I will submit and make sure to request a different schedule at runtime.