Ideally, there would be a <model>_mf function for sampling halo redshifts and masses for each model, similar to schechter_lf. This would also be ideal if we decide to move away from COLOSSUS in the future.
Then we could remove the sampling from skypy.halos.mass and have that submodule only contain functions that deal with the mass property of halos, but not the sampling.
I am having a hard time following if and how
skypy.halos.massis supposed to be used, given that there is alsoskypy.halos.colossus_mf.Ideally, there would be a
<model>_mffunction for sampling halo redshifts and masses for each model, similar toschechter_lf. This would also be ideal if we decide to move away from COLOSSUS in the future.Then we could remove the sampling from
skypy.halos.massand have that submodule only contain functions that deal with the mass property of halos, but not the sampling.