BUG: Change invalid ecsv datatype from int to uint16

skypyproject / skypy

SkyPy: A package for modelling the Universe.

BSD 3-Clause "New" or "Revised" License

118 stars 38 forks source link

BUG: Change invalid ecsv datatype from int to uint16 #485

Closed rrjbca closed 3 years ago

rrjbca commented 3 years ago

Description

In the ecsv file examples/galaxies/sdss_dered_10deg2.ecsv change the invalid datatype int to uint16. Resolves #484

Checklist

[x] Follow the Contributor Guidelines
[ ] Write unit tests
[ ] Write documentation strings
[ ] Assign someone from your working team to review this pull request
[x] Assign someone from the infrastructure team to review this pull request

Lucia-Fonseca commented 3 years ago

Q: this change will make the ecsv file compatible with astropy 4.3 and later. Would this change make it incompatible with earlier versions of astropy?

rrjbca commented 3 years ago

No, readthedocs still builds successfully with astropy 4.2. The ecvs standard has not changed and unit16 has always been valid. astropy 4.3 only restricts datatypes not specified by the standard including int.