DEV: Enable pip to install pre-releases in the tox dev environments

skypyproject / skypy

SkyPy: A package for modelling the Universe.

BSD 3-Clause "New" or "Revised" License

118 stars 38 forks source link

DEV: Enable pip to install pre-releases in the tox dev environments #491

Closed rrjbca closed 3 years ago

rrjbca commented 3 years ago

Description

Enable pip to install pre-releases in the tox dev environments. Fixes #490 since the scipy-wheels-server only hosts pre-releases and so there are no releases of numpy satisfying scipys dependency on numpy>=1.17.3. Setting pip_pre=True allows pip to install the numpy==1.22.0.dev pre-release resolving the dependency conflict. See compatibility workflow logs on the rrjbca/skypy fork e.g. HERE demonstrating successful execution of the compatibility workflow in the py39-test-dev environment.

Checklist

[x] Follow the Contributor Guidelines
[ ] Write unit tests
[ ] Write documentation strings
[ ] Assign someone from your working team to review this pull request
[x] Assign someone from the infrastructure team to review this pull request

philipp128 commented 3 years ago

You are mentioning we want to pip install the numpy pre-release numpy==1.22.0.dev but the current release is 1.21. That should satisfy issue #490, shouldn't it? There, the latest required numpy version is >=1.17.3.

rrjbca commented 3 years ago

and two tests are failing. Does it have to do with the new lines of code?

They are failing because there is no v0.4 release tag on the fork:

error: pathspec 'tags/v0.4' did not match any file(s) known to git

The fact that py39-test-dev is passing should be sufficient to demonstrate that this fix resolves the linked issue of installing dependencies in the dev environments

You are mentioning we want to pip install the numpy pre-release numpy==1.22.0.dev but the current release is 1.21. That should satisfy issue #490, shouldn't it? There, the latest required numpy version is >=1.17.3.

The purpose of this workflow is to test against pre-releases

rrjbca commented 3 years ago

I have rerun the compatibility workflow on the rrjbca/skypy fork after pushing the v0.4 tag and merging this PR into main. See the logs HERE

py39-test,main passed because it is not a dev environment and therefore is not installing nightly wheel pre-releases
py39-test,latest failed because of #482 which has been fixed on main but persists in v0.4 ("latest")
py39-test-dev,main passed as a result of this bugfix (it fails on skypyproject/skypy)
py39-test-dev,latest failed as reported in #490 because v0.4 ("latest") does not contain this bugfix

The results of the dev tests on both skypyproject/skypy and rrjbca/skypy demonstrate that this PR is sufficient to fix #490. Both "latest" tests will continue to fail until a new release is made incorporating the relevant bugfixes.