Closed philipp128 closed 2 years ago
@philipp128 are you sure the y-label should be log phi
?
I think the plot shows phi
in a log scale in contrast to log phi
in figure 9 in Lopez-Sanjuan+17. It might be confusing and I might be wrong. Could you give it a second thought?
Also in the description of the PR, if instead of saying Closes Issue 509
, you say closes 509
, the issue will be automatically closed when merging.
More about PR descriptions. We are using the convention BUG: title
for bugs, DOC: title
for documentation, and ENH: title
for enhancement
@philipp128 are you sure the y-label should be
log phi
?I think the plot shows
phi
in a log scale in contrast tolog phi
in figure 9 in Lopez-Sanjuan+17. It might be confusing and I might be wrong. Could you give it a second thought?
Yes, that's why I changed to phi. It was log(phi) but we are plotting phi.
@philipp128 are you sure the y-label should be
log phi
? I think the plot showsphi
in a log scale in contrast tolog phi
in figure 9 in Lopez-Sanjuan+17. It might be confusing and I might be wrong. Could you give it a second thought?Yes, that's why I changed to phi. It was log(phi) but we are plotting phi.
My bad, I read your description the other way round.
Description
Closes #509. Changed the y-label in the example of the Schechter Luminosity function from
log(\Phi)
to\Phi
.Checklist