BUG: Changed y-label in luminosity function example

skypyproject / skypy

SkyPy: A package for modelling the Universe.

BSD 3-Clause "New" or "Revised" License

117 stars 38 forks source link

BUG: Changed y-label in luminosity function example #512

Closed philipp128 closed 2 years ago

philipp128 commented 2 years ago

Description

Closes #509. Changed the y-label in the example of the Schechter Luminosity function from log(\Phi) to \Phi.

Checklist

[ ] Assign someone from your working team to review this pull request
[ ] Assign someone from the infrastructure team to review this pull request

Lucia-Fonseca commented 2 years ago

@philipp128 are you sure the y-label should be log phi? I think the plot shows phi in a log scale in contrast to log phi in figure 9 in Lopez-Sanjuan+17. It might be confusing and I might be wrong. Could you give it a second thought?

Lucia-Fonseca commented 2 years ago

Also in the description of the PR, if instead of saying Closes Issue 509, you say closes 509, the issue will be automatically closed when merging.

Lucia-Fonseca commented 2 years ago

More about PR descriptions. We are using the convention BUG: title for bugs, DOC: title for documentation, and ENH: title for enhancement

philipp128 commented 2 years ago

@philipp128 are you sure the y-label should be log phi?

I think the plot shows phi in a log scale in contrast to log phi in figure 9 in Lopez-Sanjuan+17. It might be confusing and I might be wrong. Could you give it a second thought?

Yes, that's why I changed to phi. It was log(phi) but we are plotting phi.

Lucia-Fonseca commented 2 years ago

@philipp128 are you sure the y-label should be log phi? I think the plot shows phi in a log scale in contrast to log phi in figure 9 in Lopez-Sanjuan+17. It might be confusing and I might be wrong. Could you give it a second thought?

Yes, that's why I changed to phi. It was log(phi) but we are plotting phi.

My bad, I read your description the other way round.