skypyproject / skypy

SkyPy: A package for modelling the Universe.
BSD 3-Clause "New" or "Revised" License
117 stars 38 forks source link

ENH: example for galaxy demographics #520

Open Lucia-Fonseca opened 2 years ago

Lucia-Fonseca commented 2 years ago

Description

This PR adds an example to reproduce Figure 3 in de la Bella et al. 2021. Include sonification feature from Strauss. Merging this PR closes #514 . Inputs:

References

Lucia-Fonseca commented 2 years ago

@rrjbca to play the audio files, I'll use this import IPython IPython.display.Audio("skypy_active.wav")

Does that mean we need to make IPython a dependency in SkyPy only to run the example?

rrjbca commented 2 years ago

@rrjbca to play the audio files, I'll use this import IPython IPython.display.Audio("skypy_active.wav")

Does that mean we need to make IPython a dependency in SkyPy only to run the example?

Sorry I only just saw this. Yes you should just add ipython as an extra requirement for docs in setup.cfg. I tested this locally and it worked fine.

Lucia-Fonseca commented 2 years ago

test_smail fails and the checks don't pass

rrjbca commented 2 years ago

test_smail fails

Check the logs, it's a kstest failure, just re-run it

Lucia-Fonseca commented 2 years ago

The docs are not picking up the latest changes but it renders well on my local machine. This needs #516 to be merged before this is ready.